Thread (27 messages) 27 messages, 5 authors, 2016-02-15

[PATCH 01/14] mfd: intel_quark_i2c_gpio: Use clkdev_create()

From: Stephen Boyd <hidden>
Date: 2016-02-10 18:35:14
Also in: linux-clk, lkml

On 02/10, Lee Jones wrote:
On Mon, 08 Feb 2016, Stephen Boyd wrote:
quoted
Convert this driver to use clkdev_create() instead of
clk_register_clkdevs(). The latter API is only used by this driver,
although this driver only allocates one clk to add anyway.
Furthermore, this driver allocates the clk_lookup structure with
devm, but clkdev_drop() will free that structure when passed,
leading to a double free when this driver is removed. Clean it
all up and pave the way for the removal of clk_register_clkdevs().

Cc: Lee Jones <redacted>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Russell King <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/mfd/intel_quark_i2c_gpio.c | 26 +++++++++-----------------
 1 file changed, 9 insertions(+), 17 deletions(-)
I never much liked this code [0]

Glad for it to be simplified.

Applied, thanks.
Can you please ack the patch instead? I'd like to take it through
the clk tree so that I can remove clk_register_clkdevs() as well.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help