[PATCH v2 4/4] iommu/arm-smmu: Add stub of_xlate() operation in SMMUv1/SMMUv2 driver
From: mark.rutland@arm.com (Mark Rutland)
Date: 2016-02-08 11:19:06
Also in:
linux-devicetree, linux-iommu, lkml
On Mon, Feb 08, 2016 at 10:47:32AM +0530, Anup Patel wrote:
quoted hunk ↗ jump to hunk
To allow use of large memory (> 4Gb) with 32bit devices we need to use IOMMU based DMA mappings for such 32bit devices. The IOMMU dt-bindings allows us do this by specifying 'iommus' attribute in 32bit device DT node. Unfortunately, specifying 'iommus' attribute does not work with current SMMUv1/SMMUv2 driver because it requires of_xlate() operation to be implemented by the driver. This patch adds a stub implementation of of_xlate() in SMMUv1/SMMUv2 driver to allow usage of 'iommus' attribute in DT for 32bit devices. Signed-off-by: Anup Patel <redacted> Reviewed-by: Ray Jui <rjui@broadcom.com> Reviewed-by: Scott Branden <sbranden@broadcom.com> --- drivers/iommu/arm-smmu.c | 11 +++++++++++ 1 file changed, 11 insertions(+)diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 02cd67d..8e090d8 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c@@ -1398,6 +1398,16 @@ static int arm_smmu_init_platform_device(struct device *dev, return 0; } +int arm_smmu_of_xlate(struct device *dev, struct of_phandle_args *args) +{ + /* + * Nothing to do here because SMMU is already aware of all + * MMU masters and their stream IDs using mmu-master attibute + * SMMU DT node. + */ + return 0; +}
NAK to this. As previously mentioned by others [1], this is an abuse of the generic iommu binding support code. The SMMU binding currently does not define its implementation of the generic IOMMU binding. This series did not define what an SMMU's #iommu-cells would be nor what the contained values would represent. Therefore it is not valid to use an SMMU node with an iommus property as the SMMu doesn't follwo the generic IOMMU binding. There is ongoing work to have generic iommu binding support for the SMMU. In the absence of documentation for what this means for the binding, I am worried that this hack harms that effort. To use features of the generic IOMMU binding, we must properly implement the generic IOMMU binding for the SMMU rather than bodging it onto the side of the existing binding. Thanks, Mark.
quoted hunk ↗ jump to hunk
+ static int arm_smmu_add_device(struct device *dev) { struct iommu_group *group;@@ -1495,6 +1505,7 @@ static struct iommu_ops arm_smmu_ops = { .unmap = arm_smmu_unmap, .map_sg = default_iommu_map_sg, .iova_to_phys = arm_smmu_iova_to_phys, + .of_xlate = arm_smmu_of_xlate, .add_device = arm_smmu_add_device, .remove_device = arm_smmu_remove_device, .device_group = arm_smmu_device_group,-- 1.9.1
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/402976.html