From: Heinrich Schuchardt <hidden> Date: 2016-02-06 11:31:48
Downstream packages like Debian flash-install use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model identifier.
https://lkml.org/lkml/2014/7/8/579 created the new file
imx6q-wandboard-revb1.dts but used the same model identifier
as in imx6q-wandboard.dts.
This patch provides a unique model identifier for revision B1 of
the Wandboard Quad.
Signed-off-by: Heinrich Schuchardt <redacted>
---
arch/arm/boot/dts/imx6q-wandboard-revb1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Heinrich Schuchardt <hidden> Date: 2016-02-06 12:07:52
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model identifier.
https://lkml.org/lkml/2014/7/8/579 created the new file
imx6q-wandboard-revb1.dts but used the same model identifier
as in imx6q-wandboard.dts.
This patch provides a unique model identifier for revision B1 of
the Wandboard Quad.
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>
---
arch/arm/boot/dts/imx6q-wandboard-revb1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Sat, Feb 6, 2016 at 10:06 AM, Heinrich Schuchardt [off-list ref] wrote:
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model identifier.
https://lkml.org/lkml/2014/7/8/579 created the new file
imx6q-wandboard-revb1.dts but used the same model identifier
as in imx6q-wandboard.dts.
This patch provides a unique model identifier for revision B1 of
the Wandboard Quad.
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>
From: Robert Nelson <hidden> Date: 2016-02-07 23:53:23
On Sat, Feb 6, 2016 at 6:06 AM, Heinrich Schuchardt [off-list ref] wrote:
quoted hunk
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model identifier.
https://lkml.org/lkml/2014/7/8/579 created the new file
imx6q-wandboard-revb1.dts but used the same model identifier
as in imx6q-wandboard.dts.
This patch provides a unique model identifier for revision B1 of
the Wandboard Quad.
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>
---
arch/arm/boot/dts/imx6q-wandboard-revb1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Okay, this seems a little silly....
The wandboard has 5 versions:
solo: imx6dl-wandboard-revb1.dts
model = "Wandboard i.MX6 Dual Lite Board";
dual rev b: imx6dl-wandboard-revb1.dts
model = "Wandboard i.MX6 Dual Lite Board";
dual rev c: imx6dl-wandboard.dts
model = "Wandboard i.MX6 Dual Lite Board";
quad rev b: imx6q-wandboard-revb1.dts
model = "Wandboard i.MX6 Quad Board"; - > model = "Wandboard i.MX6
Quad Board rev B1";
quad rev c: imx6q-wandboard.dts
model = "Wandboard i.MX6 Quad Board";
Do you guys see the issue? Either we change them "ALL", rev b or rev c...
Or "flash-kernel" needs to learn to copy more then one dtb (in this
case 5 *.dtb's)
PS, u-boot already can boot on all these with the same SPL/u-boot
image and detect which board and load the correct device tree binary..
Regards,
--
Robert Nelson
https://rcn-ee.com/
From: Heinrich Schuchardt <hidden> Date: 2016-02-08 00:26:20
On 08.02.2016 00:52, Robert Nelson wrote:
On Sat, Feb 6, 2016 at 6:06 AM, Heinrich Schuchardt [off-list ref] wrote:
quoted
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model identifier.
https://lkml.org/lkml/2014/7/8/579 created the new file
imx6q-wandboard-revb1.dts but used the same model identifier
as in imx6q-wandboard.dts.
This patch provides a unique model identifier for revision B1 of
the Wandboard Quad.
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>
---
arch/arm/boot/dts/imx6q-wandboard-revb1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Okay, this seems a little silly....
The wandboard has 5 versions:
solo: imx6dl-wandboard-revb1.dts
model = "Wandboard i.MX6 Dual Lite Board";
dual rev b: imx6dl-wandboard-revb1.dts
model = "Wandboard i.MX6 Dual Lite Board";
dual rev c: imx6dl-wandboard.dts
model = "Wandboard i.MX6 Dual Lite Board";
quad rev b: imx6q-wandboard-revb1.dts
model = "Wandboard i.MX6 Quad Board"; - > model = "Wandboard i.MX6
Quad Board rev B1";
quad rev c: imx6q-wandboard.dts
model = "Wandboard i.MX6 Quad Board";
Do you guys see the issue? Either we change them "ALL", rev b or rev c...
Or "flash-kernel" needs to learn to copy more then one dtb (in this
case 5 *.dtb's)
PS, u-boot already can boot on all these with the same SPL/u-boot
image and detect which board and load the correct device tree binary..
Regards,
Hello Robert,
I only see four dts files mentioned in your mail (solo using the same as
dual rev B1).
We do not know if imx6dl-wandboard.dts and imx6q-wandboard.dts
will support future revisions of the boards. So it doesn't make
much sense to mark them as restricted to revision C1.
You are right in that we should add a change to
imx6dl-wandboard-revb1.dts to the same patch.
Best regards
Heinrich Schuchardt
From: Heinrich Schuchardt <hidden> Date: 2016-02-08 00:59:03
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model
identifier.
Commit 8536239e371f ("ARM: dts: Restructure imx6qdl-wandboard.dtsi for new
rev C1 board.")' created new files imx6dl-wandboard-revb1.dts and
imx6q-wandboard-revb1.dts but used the same model identifier as in
imx6dl-wandboard.dts and imx6q-wandboard.dts.
This patch provides unique model identifiers for revision B1 of
the Wandboard Dual and Wandbaord Quad.
The patch leaves imx6dl-wandboard.dts and imx6q-wandboard.dts unchanged
because it is not foreseeable if the same dts will valid for future
board revisions or not. Furthermore we should avoid unnecessary
changes.
v3:
update imx6dl-wandboard-revb1.dts
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>
---
arch/arm/boot/dts/imx6dl-wandboard-revb1.dts | 2 +-
arch/arm/boot/dts/imx6q-wandboard-revb1.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
On Mon, Feb 08, 2016 at 01:55:08AM +0100, Heinrich Schuchardt wrote:
Downstream packages like Debian flash-kernel use
/proc/device-tree/model
to determine which dtb file to install.
Hence each dts in the Linux kernel should provide a unique model
identifier.
Commit 8536239e371f ("ARM: dts: Restructure imx6qdl-wandboard.dtsi for new
rev C1 board.")' created new files imx6dl-wandboard-revb1.dts and
imx6q-wandboard-revb1.dts but used the same model identifier as in
imx6dl-wandboard.dts and imx6q-wandboard.dts.
This patch provides unique model identifiers for revision B1 of
the Wandboard Dual and Wandbaord Quad.
The patch leaves imx6dl-wandboard.dts and imx6q-wandboard.dts unchanged
because it is not foreseeable if the same dts will valid for future
board revisions or not. Furthermore we should avoid unnecessary
changes.
v3:
update imx6dl-wandboard-revb1.dts
v2:
correct name of referenced Debian package
Signed-off-by: Heinrich Schuchardt <redacted>