[PATCH V2 6/6] coresight-stm: adding driver for CoreSight STM component

From
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Date
2016-02-05 13:06:34
Also in
linux-api, lkml
Reply to
Chunyan Zhang, 2016-02-03
Chunyan Zhang [off-list ref] writes:
quoted hunk ↗ jump to hunk
+#ifndef CONFIG_64BIT
+static inline void __raw_writeq(u64 val, volatile void __iomem *addr)
+{
+	asm volatile("strd %1, %0"
+		     : "+Qo" (*(volatile u64 __force *)addr)
+		     : "r" (val));
+}
Is it really ok to do this for all !64bit arms, inside a driver, just
like that? I'm not an expert, but I'm pretty sure there's more to it.

Regards,
--
Alex
Thread (27 messages) 27 messages, 7 authors, last reply 2016-02-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help