Hi Arnd

Thanks for looking at this

-----Original Message-----
From: Arnd Bergmann [mailto:arnd at arndb.de]
Sent: 04 February 2016 13:12
To: Gabriele Paoloni
Cc: Guohanjun (Hanjun Guo); Wangzhou (B); liudongdong (C); Linuxarm;
qiujiang; bhelgaas at google.com; Lorenzo.Pieralisi at arm.com;
tn at semihalf.com; zhangjukuo; xuwei (O); Liguozhu (Kenneth); linux-
pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-
acpi at vger.kernel.org; linux-kernel at vger.kernel.org; jcm at redhat.com
Subject: Re: [RFC PATCH 0/4] Add ACPI support for HiSilicon PCIe Host
Controllers

On Thursday 04 February 2016 19:37:36 Gabriele Paoloni wrote:

quoted

From: gabriele paoloni <redacted>

This patchset adds ACPI support for the HiSilicon Hip05/Hip06 SoC

PCIe controllers

quoted

The four patches respectively:
        - rework PCie Designware to be used for ACPI PCI Host

controllers

quoted

        - re-architect the current HiSilicon driver to make it

scalable to the

quoted

          new ACPI quirks
        - rework the current HiSilicon driver to make it ECAM

compliant

quoted

        - adds the HiSilicon ACPI specific quirks.

   This patchset  is based on
   https://github.com/semihalf-nowicki-tomasz/linux.git
   branch pci-acpi-v3 + Hip06 support applied on top:
   https://patchwork.ozlabs.org/patch/549198/

ACPI has its own PCI support, and should not need drivers for host
bridges. I don't think we can really mix the two things, as ACPI
needs to have access to things like PCI config space way before
we are probing normal device drivers.

Please put this in drivers/acpi/pci*.c.

I can put pcie-hisi-acpi.c under drivers/acpi/

However if you look at the driver it is made up of three parts:
pcie-hisi.c --> the DT based driver
pcie-hisi-acpi.c --> the ACPI based hook and ACPI specific init callback
pcie-hisi-common.c --> common functions shared between DT and ACPI versions 
                       of the driver

Now I think that moving pcie-hisi-acpi.c under drivers/acpi/
would make it hard to read as you need to jump across directories
and it seems a bit unnatural...

However it is not a big issue to me...

Cheers

Gab

	Arnd