[PATCH 0/5] Clean up warnings (part 2, asm/pci-bridge.h)
From: Will Deacon <hidden>
Date: 2016-02-03 09:25:08
Also in:
linux-pci, lkml
From: Will Deacon <hidden>
Date: 2016-02-03 09:25:08
Also in:
linux-pci, lkml
On Tue, Feb 02, 2016 at 01:38:26PM -0600, Bjorn Helgaas wrote:
We've had some non-arch-specific stuff (pci_has_flag() and associated definitions like PCI_PROBE_ONLY) in asm/pci-bridge.h. This leads to warnings like: drivers/pci/host/pcie-designware.c:562:20: error: 'PCI_PROBE_ONLY' undeclared (first use in this function) drivers/pci/host/pcie-designware.c:562:7: error: implicit declaration of function 'pci_has_flag' [-Werror=implicit-function-declaration] because arches don't consistently supply asm/pci-bridge.h, and several drivers include it when they shouldn't. This series moves the generic stuff to linux/pci.h, so it's the same for everybody, and removes the now-empty asm-generic/pci-bridge.h. There still a few arches that provide asm/pci-bridge.h (microblaze, powerpc, and xtensa), but now they contain truly arch-dependent things like struct pci_controller definitions, and they're only included by arch-specific files.
For the arm64 bits: Acked-by: Will Deacon <redacted> Will