[PATCH v2 net 3/6] net: mvneta: Remove unused code

Hi Sergei,
 
 On lun., f?vr. 01 2016, Sergei Shtylyov [off-list ref] wrote:

Hello.

On 2/1/2016 4:07 PM, Gregory CLEMENT wrote:

quoted

Since the commit 2dcf75e2793c ("net: mvneta: Associate RX queues with
each CPU") all the percpu irq are used and unmask at initialization, so

   Unmasked, you mean?

yes and disabled would be more appropriate actually.

quoted

there is no point to unmask them first.

   Mask, maybe (looking at the patch)?

not mask, but here again disable would be more appropriate. The code
removed disables the interrupt.


Thanks,

Gregory

quoted

Signed-off-by: Gregory CLEMENT <redacted>
---
  drivers/net/ethernet/marvell/mvneta.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 3d6e3137f305..861b7e0d7d5f 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c

@@ -3009,14 +3009,6 @@ static int mvneta_open(struct net_device *dev)
  		goto err_cleanup_txqs;
  	}

-	/* Even though the documentation says that request_percpu_irq
-	 * doesn't enable the interrupts automatically, it actually
-	 * does so on the local CPU.
-	 *
-	 * Make sure it's disabled.
-	 */
-	mvneta_percpu_disable(pp);
-
  	/* Enable per-CPU interrupt on all the CPU to handle our RX
  	 * queue interrupts
  	 */

MBR, Sergei

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com