On Sat, Jan 30, 2016 at 11:34:50AM +0100, Ard Biesheuvel wrote:

On 30 January 2016 at 00:46, Laura Abbott [off-list ref] wrote:

quoted

create_mapping is only used in fixmap_remap_fdt. All the create_mapping
calls need to happen on existing translation table pages without
additional allocations. Rather than have an alloc function be called
and fail, just set it to NULL and catch it's use. Also change

s/it's/its/

quoted

the name to create_mapping_noalloc to better capture what exactly is
going on.

Signed-off-by: Laura Abbott <redacted>

With one nit below:
Reviewed-by: Ard Biesheuvel <redacted>

[...]

quoted

+/*
+ * This function is for mapping using existing sections only.

Could you improve this comment? 'existing sections' does not quite
cover what we expect to deal with imo

quoted

+ */
+static void __init create_mapping_noalloc(phys_addr_t phys, unsigned long virt,
                                  phys_addr_t size, pgprot_t prot)

Perhaps:

/*
 * This function can only be used to modify existing table entries,
 * without allocating new levels of table. Note that this permits the
 * creation of new section or page entries.
 */

Either way:

Reviewed-by: Mark Rutland <mark.rutland@arm.com>

Thanks for putting this together!

Mark.