Thread (9 messages) 9 messages, 7 authors, 2016-01-28

[PATCH 1/2] ARM: shmobile: Move shmobile_scu_base from .text to .data

flat view
STALE3918d

From: Sergei Shtylyov <hidden>
Date: 2016-01-28 15:37:19

Revision v1 of 3 in this series.

Revisions (3)
  1. v1
  2. v1 current
  3. v1
Hello.

On 01/28/2016 06:04 PM, Geert Uytterhoeven wrote:
shmobile_scu_base is being written to, so it doesn't belong in the .text
section. Fix this by moving it from asm .text to C .data, as it's no
longer used from asm code since commit 4f6da36f7edd5790 ("ARM: shmobile:
Remove old SCU boot code").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
[...]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-shmobile/platsmp-scu.c b/arch/arm/mach-shmobile/platsmp-scu.c
index 64663110ab6ca0e1..f2198c9c74359736 100644
--- a/arch/arm/mach-shmobile/platsmp-scu.c
+++ b/arch/arm/mach-shmobile/platsmp-scu.c
@@ -17,6 +17,9 @@
  #include <asm/smp_scu.h>
  #include "common.h"

+
    Why add 2nd empty line?
quoted hunk ↗ jump to hunk
+void __iomem *shmobile_scu_base;
+
  static int shmobile_smp_scu_notifier_call(struct notifier_block *nfb,
  					  unsigned long action, void *hcpu)
  {
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help