[PATCH v2 3/6] irqchip: irq-armada-370-xp: use PCI_MSI_DOORBELL_START where appropriate
DORMANTno replies
REVIEWED: 1 (0M)
From: Gregory CLEMENT <hidden>
Date: 2016-01-27 13:39:23
1 review trailer.
Hi Thomas, On mer., janv. 27 2016, Thomas Petazzoni [off-list ref] wrote:
As suggested by Gregory Clement, this commit adjusts the irq-armada-370-xp driver to use the PCI_MSI_DOORBELL_START define in the armada_370_xp_handle_msi_irq() function, rather than hardcoding its value. Suggested-by: Gregory CLEMENT <redacted> Signed-off-by: Thomas Petazzoni <redacted>
Acked-by: Gregory CLEMENT <redacted> Thanks, Gregory
quoted hunk
--- drivers/irqchip/irq-armada-370-xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index e5738c5..f53eb71 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c@@ -401,10 +401,10 @@ static void armada_370_xp_handle_msi_irq(struct pt_regs *regs, bool is_chained) if (is_chained) { irq = irq_find_mapping(armada_370_xp_msi_inner_domain, - msinr - 16); + msinr - PCI_MSI_DOORBELL_START); generic_handle_irq(irq); } else { - irq = msinr - 16; + irq = msinr - PCI_MSI_DOORBELL_START; handle_domain_irq(armada_370_xp_msi_inner_domain, irq, regs); }-- 2.6.4
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com