Thread (11 messages) 11 messages, 4 authors, 2016-01-19
STALE3810d
Revisions (4)
  1. v1 [diff vs current]
  2. v1 current
  3. v1 [diff vs current]
  4. v2 [diff vs current]

[PATCH 3/5] ARM: OMAP2+: Fix save_secure_ram_context for rodata

From: Sergei Shtylyov <hidden>
Date: 2016-01-19 18:45:51
Also in: linux-omap

Hello.

On 01/19/2016 08:48 PM, Tony Lindgren wrote:
quoted hunk ↗ jump to hunk
We don't want to write to .text and we can move save_secure_ram_context
into .data as it all gets copied into SRAM anyways.

Cc: Kees Cook <redacted>
Cc: Laura Abbott <redacted>
Cc: Nicolas Pitre <redacted>
Cc: Nishanth Menon <redacted>
Cc: Richard Woodruff <redacted>
Cc: Russell King <redacted>
Cc: Tero Kristo <redacted>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
  arch/arm/mach-omap2/sleep34xx.S | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S
index f7c7bf8..042e4fb 100644
--- a/arch/arm/mach-omap2/sleep34xx.S
+++ b/arch/arm/mach-omap2/sleep34xx.S
@@ -93,8 +93,12 @@ ENTRY(enable_omap3630_toggle_l2_on_restore)
  	ldmfd	sp!, {pc}	@ restore regs and return
  ENDPROC(enable_omap3630_toggle_l2_on_restore)

-	.text
-/* Function to call rom code to save secure ram context */
+/*
+ * Function to call rom code to save secure ram context, This gets
    s/,/./?
+ * relocated to SRAM, so it can be all in .data section. Otherwise
+ * we need to initialize api_params separately.
+ */
+	.data
  	.align	3
  ENTRY(save_secure_ram_context)
  	stmfd	sp!, {r4 - r11, lr}	@ save registers on stack
[...]

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help