[PATCH v3 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq
From: bp@alien8.de (Borislav Petkov)
Date: 2016-01-10 11:07:14
Also in:
linux-acpi
On Fri, Nov 06, 2015 at 05:51:58PM -0700, Loc Ho wrote:
quoted hunk ↗ jump to hunk
The function acpi_gsi_to_irq should returns 0 on success as upper function caller expect an 0 for sucesss. Signed-off-by: Tuan Phan <redacted> Signed-off-by: Loc Ho <redacted> --- drivers/acpi/gsi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c index fa4585a..0ed1003 100644 --- a/drivers/acpi/gsi.c +++ b/drivers/acpi/gsi.c@@ -43,7 +43,7 @@ static unsigned int acpi_gsi_get_irq_type(int trigger, int polarity) * * irq location updated with irq value [>0 on success, 0 on failure] * - * Returns: linux IRQ number on success (>0) + * Returns: 0 on success * -EINVAL on failure */ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq)@@ -56,7 +56,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) * *irq == 0 means no mapping, that should * be reported as a failure */ - return (*irq > 0) ? *irq : -EINVAL; + return (*irq > 0) ? 0 : -EINVAL; } EXPORT_SYMBOL_GPL(acpi_gsi_to_irq);
That function can be simplified. It should be made to return the irq
number on success and 0 on failure. No need for that *irq output
argument.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.