Thread (5 messages) 5 messages, 2 authors, 2016-01-28

[PATCH 2/2 V3] drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic

From: Gang Liu <hidden>
Date: 2016-01-25 07:47:26
Also in: linux-gpio

Hi, Linus Walleij,

I rewrote the patches following your comments based on the gpio-generic infrastructure. 
Do you have some comments for the new patches? Or could you please help to apply the patches?

Thanks!
Liu Gang

-----Original Message-----
From: Liu Gang [mailto:Gang.Liu at nxp.com] 
Sent: Tuesday, January 12, 2016 8:10 PM
To: linus.walleij at linaro.org; linux-gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org
Cc: robh+dt at kernel.org; Bhupesh Sharma <redacted>; scottwood at nxp.com; LeoLi at nxp.com; Gang Liu <redacted>; Gang Liu <redacted>
Subject: [PATCH 2/2 V3] drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic

The new Layerscape platforms has the same ip block/controller as GPIO on PowerPC platforms(MPC8XXX), but the GPIO registers may be big or little endian. So the code needs to get the endian property from DTB, then make additional functions to fit all the PowerPC/Layerscape GPIO register read/write operations.

gpio-generic.c provides an universal infrastructure for both big and little endian register operations. So switch the gpio-mpc8xxx to use gpio-generic can simplify the driver and reduce a lot of code.

The IRQ and some workaround parts in gpio-mpc8xxx.c will be updated with the new API interfaces but following the original functionalities.

Signed-off-by: Liu Gang <redacted>
---
-V3: Switch gpio-mpc8xxx to use gpio-generic for both
     little, big endian kinds of GPIO register following
     Linus Walleij comments.

 drivers/gpio/gpio-mpc8xxx.c | 270 ++++++++++++++++++--------------------------
 1 file changed, 109 insertions(+), 161 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help