Thread (1 message) 1 message, 1 author, 2016-01-28

[PATCH] spi: atmel: fix gpio chip-select in case of non-DT platform

From: Måns Rullgård <hidden>
Date: 2016-01-28 16:00:29
Also in: linux-spi, lkml, stable

Nicolas Ferre [off-list ref] writes:
From: Cyrille Pitchen <redacted>

The non-DT platform that uses this driver (actually the AVR32) was taking a bad
branch for determining if the IP would use gpio for CS.
Adding the presence of DT as a condition fixes this issue.

Signed-off-by: Cyrille Pitchen <redacted>
[nicolas.ferre at atmel.com: extract from ml discussion]
Reported-by: Mans Rullgard <redacted>
Fixes: 4820303480a1 ("spi: atmel: add support for the internal chip-select of the spi controller")
Cc: <redacted> # 4.2+
Signed-off-by: Nicolas Ferre <redacted>
Tested-by: Mans Rullgard <redacted>
quoted hunk
---
 drivers/spi/spi-atmel.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index aebad36391c9..8feac599e9ab 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1571,6 +1571,7 @@ static int atmel_spi_probe(struct platform_device *pdev)

 	as->use_cs_gpios = true;
 	if (atmel_spi_is_v2(as) &&
+	    pdev->dev.of_node &&
 	    !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
 		as->use_cs_gpios = false;
 		master->num_chipselect = 4;
-- 
2.1.3
-- 
M?ns Rullg?rd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help