Thread (7 messages) 7 messages, 3 authors, 2016-01-28

[PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

flat view

From: horms@verge.net.au (Simon Horman)
Date: 2016-01-27 23:39:59
Also in: lkml, lvs-devel, netdev, netfilter-devel

On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote:
	Hello,

On Wed, 27 Jan 2016, Arnd Bergmann wrote:
quoted
The proc_create() and remove_proc_entry() functions do not reference
their arguments when CONFIG_PROC_FS is disabled, so we get a couple
of warnings about unused variables in IPVS:

ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable]
ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable]
ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable]

This removes the local variables and instead looks them up separately
for each use, which obviously avoids the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning")
	Looks like your previous patch for ip_vs_app_net_cleanup
was delayed in ipvs-next tree. I guess, Simon should drop it and
use this one instead when net-next opens:

Acked-by: Julian Anastasov <ja@ssi.bg>
Thanks, and sorry about not pushing the other patch to net-next.
I have dropped it and queued up this one in its place.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help