[PATCH] mmc: omap_hsmmc: don't print uninitialized variables
From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-01-26 15:19:01
Also in:
linux-mmc, linux-omap, lkml
From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-01-26 15:19:01
Also in:
linux-mmc, linux-omap, lkml
On Tuesday 26 January 2016 16:52:40 Peter Ujfalusi wrote:
quoted
@@ -2133,7 +2131,17 @@ static int omap_hsmmc_probe(struct platform_device *pdev) omap_hsmmc_conf_bus_power(host); - if (!pdev->dev.of_node) { + host->tx_chan = dma_request_slave_channel(&pdev->dev, "tx"); + host->rx_chan = dma_request_slave_channel(&pdev->dev, "rx"); + if (!host->tx_chan || !host->rx_chan) {While it is really unlikely that we are failing to get only one of the channels... It means anyway that the omap_hsmmc is not usable, but we will still try to get via legacy mode and there is a chance that we might get some channel. Too bad that I can not send the conversion to dma_request_chan() yet due to missing things in arch... It might be simpler to just remove the printout of the rx/tx_req from the dev_err() when reporting failed channel requests...
Fine with me too, I'll send that patch as well and let Ulf pick. Arnd