Thread (3 messages) flat view 3 messages, 3 authors, 2016-02-01

[PATCH] ARM: bcm: use const and __initconst for smp_operations

From: rjui@broadcom.com (Ray Jui)
Date: 2016-01-25 17:15:53
Also in: lkml

Hi Masahiro,

On 1/25/2016 3:31 AM, Masahiro Yamada wrote:
quoted hunk ↗ jump to hunk
This newly added code missed the global fixup by commit 75305275a721
("ARM: use const and __initconst for smp_operations").  So fix it now.

Also, add missing "static" qualifier.

Signed-off-by: Masahiro Yamada <redacted>
---

  arch/arm/mach-bcm/platsmp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
index 575defc..cfae9c7 100644
--- a/arch/arm/mach-bcm/platsmp.c
+++ b/arch/arm/mach-bcm/platsmp.c
@@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = {
  CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method",
  			&bcm_smp_ops);

-struct smp_operations nsp_smp_ops __initdata = {
+static const struct smp_operations nsp_smp_ops __initconst = {
  	.smp_prepare_cpus	= bcm_smp_prepare_cpus,
  	.smp_boot_secondary	= nsp_boot_secondary,
  };
This fix looks good to me. Thanks!

Reviewed-by: Ray Jui <rjui@broadcom.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help