Thread (2 messages) 2 messages, 2 authors, 2016-01-25

[PATCH v2] of: drop symbols declared by _OF_DECLARE() from modules

flat view

From: robh@kernel.org (Rob Herring)
Date: 2016-01-25 14:54:42
Also in: linux-devicetree, lkml

On Thu, Jan 21, 2016 at 10:33 AM, Masahiro Yamada
[off-list ref] wrote:
The users of this macro (OF_EARLYCON_DECLARE, CLK_OF_DECLARE,
IRQCHIP_DECLARE, etc.) are only parsed in the early boot stage.
Such symbols contained in modules are never used.

This commit fixes the link error introduced by commit b8d20e06eaad
("serial: 8250_uniphier: add earlycon support"); the combination
of CONFIG_SERIAL_8250_UNIPHIER=m and CONFIG_SERIAL_8250_CONSOLE=y
fails to link:

ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!

Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
Signed-off-by: Masahiro Yamada <redacted>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---

Changes in v2:
  - Describe the bug fixed by this commit

 include/linux/of.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help