Thread (5 messages) 5 messages, 4 authors, 2016-01-20

[RFC PATCH v3] irqchip: Add support for Tango interrupt controller

flat view

From: Marc Zyngier <hidden>
Date: 2016-01-20 16:23:19
Also in: lkml

On 20/01/16 16:10, M?ns Rullg?rd wrote:
Marc Zyngier [off-list ref] writes:
quoted
quoted
+	if (of_property_read_u32(node, "reg", &ctl))
+		panic("%s: failed to get reg base", node->name);
+
+	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
+	chip->ctl = ctl;
+	chip->base = base;
As I said before, this assumes the outer DT node uses a ranges
property.  Normally reg properties work the same whether they specify an
offset within an outer "ranges" or have a full address directly.  It
would be easy enough to make this work with either, so I don't see any
reason not to.
Yup, that is a good point. I guess Marc can address this in the next
round, since we need a DT binding anyway.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help