Thread (1 message) 1 message, 1 author, 2016-01-12

[PATCH v2] spi: atmel: improve internal vs gpio chip-select choice

From: Måns Rullgård <hidden>
Date: 2016-01-12 08:51:10
Also in: linux-spi, lkml

Cyrille Pitchen [off-list ref] writes:
Hi Mans,

I've tried to apply your patch on a next-20160112 branch to test it but it
failed. I've also looked at the for-next branch of the SPI sub-system git
tree.

It seems that one issue occurred within a chunk patching the atmel_spi_setup()
function. Please see below.

Le 11/01/2016 17:01, Mans Rullgard a ?crit :
[...]
quoted
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 08cbb3e43c76..d4a806e24060 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
[...]
quoted
@@ -1603,6 +1611,7 @@ static int atmel_spi_setup(struct spi_device *spi)
 		}
 
 		asd->npcs_pin = npcs_pin;
+		asd->use_cs_gpio = use_cs_gpio;
 		spi->controller_state = asd;
 	} else {
 		atmel_spi_lock(as);
[...]

There is no 'else' statement in the source code I'm looking at.
Sorry, I'll send a new patch against the correct base.  I forgot I had
something else earlier in my local branch.

-- 
M?ns Rullg?rd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help