[PATCH 1/2] power: act8945a: add charger driver for ACT8945A

Hi Javier,

Thank you for your review.

-----Original Message-----
From: Javier Martinez Canillas [mailto:javier at dowhile0.org]
Sent: 2016?1?8? 23:00
To: Yang, Wenyou <redacted>
Cc: Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov
[off-list ref]; David Woodhouse [off-list ref]; Rob
Herring [off-list ref]; Pawel Moll [off-list ref]; Mark
Rutland [off-list ref]; Ian Campbell [off-list ref];
Kumar Gala [off-list ref]; Ferre, Nicolas
[off-list ref]; linux-arm-kernel at lists.infradead.org; Linux
Kernel [off-list ref]; linux-pm at vger.kernel.org
Subject: Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A

Hello Wenyou,

On Thu, Jan 7, 2016 at 11:13 PM, Wenyou Yang [off-list ref]
wrote:

quoted

This patch adds new driver for Active-semi ACT8945A ActivePath charger
(part of ACT8945A MFD driver) providing power supply class information
to userspace.

The driver is configured through DTS (battery and system related
settings) and sysfs entries (timers and input over-voltage threshold).

Signed-off-by: Wenyou Yang <redacted>
---

[snip]

quoted

+
+static struct platform_driver act8945a_charger_driver = {
+       .driver = {
+               .name = "act8945a-charger",
+       },
+       .probe  = act8945a_charger_probe,
+       .remove = act8945a_charger_remove, };
+

The driver is missing an OF match table (and also a platform ID match table if
non-DT is supported) so this means that module autoloading will be broken for this
driver since the platform uevent function will report a MODALIAS=of:N*T*Cactive-
semi,act8945a-charger

This is an MFD device, it compatible is declared in the ../mfd/act8945a.c file.

	.of_compatible = "active-semi,act8945a-charger".

The non-DT  is not supported in this patch. So a platform ID match table is not included.

Matching is only working because the platform bus match function use as a
fallback the driver name.

Best regards,
Javier

Best Regards,
Wenyou Yang