Thread (4 messages) 4 messages, 2 authors, 2016-01-12

[PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM

From: Takashi Iwai <hidden>
Date: 2016-01-11 09:02:27
Also in: alsa-devel, linux-mediatek, lkml

On Mon, 11 Jan 2016 09:00:50 +0100,
PC Liao wrote:
quoted hunk ↗ jump to hunk
@@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
 	if (ret < 0)
 		return ret;
 
-	memif->phys_buf_addr = substream->runtime->dma_addr;
+	if (sizeof(dma_addr_t) > 4)
+		msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;
Better to put a proper suffix for the constant over 32bit.

Or use upper_32_bits().  Then sizeof() check can be omitted, as the
compiler should be smart enough to know it beforehand.


Takashi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help