Thread (10 messages) 10 messages, 3 authors, 2016-01-07

net-thunder: One check less in nicvf_register_interrupts() after error detection

From: joe@perches.com (Joe Perches)
Date: 2016-01-07 20:42:12
Also in: kernel-janitors, lkml, netdev

On Thu, 2016-01-07 at 21:38 +0100, SF Markus Elfring wrote:
quoted
Some prefer that source code be "templatized" regardless
of the number of exit points that any particular use of a
specific function type.
[]
quoted
Some of your patches are converting these templatized
functions to a different form for no added value.
Would you like to distinguish a bit more between my evolving
collection of update suggestions and the concrete proposal
for the function "nicvf_register_interrupts"?
No.
quoted
These patches make the local source code inconsistent
and generally goes against the authors preferred style.
Which programming approach will be the leading one here finally?
Whatever the developer wants.

There is no _best_ or _only_ style for this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help