Thread (15 messages) 15 messages, 3 authors, 2016-01-11

[PATCH 2/3] drm: arm-hdlcd: remove COMMON_CLK_SCPI select

flat view
STALE3938d

From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-01-01 14:39:29
Also in: dri-devel, lkml
Subsystem: arm mali-dp drm driver, drm drivers, drm drivers and misc gpu patches, the rest · Maintainers: Liviu Dudau, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds

The hdlcd driver has no build-time dependency on the SCPI clock
and the bogus 'select' causes a warning when SCPI is disabled:

warning: (DRM_HDLCD) selects COMMON_CLK_SCPI which has unmet direct dependencies (COMMON_CLK && (ARM_SCPI_PROTOCOL || COMPILE_TEST))

This removes the select statement.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Found two more bugs in the same driver, so this is now a patch series
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
index 2f4d3b7fb871..81ea7802ca50 100644
--- a/drivers/gpu/drm/arm/Kconfig
+++ b/drivers/gpu/drm/arm/Kconfig
@@ -9,7 +9,6 @@ config DRM_HDLCD
 	tristate "ARM HDLCD"
 	depends on DRM_ARM
 	depends on COMMON_CLK
-	select COMMON_CLK_SCPI
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	help
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help