Thread (19 messages) 19 messages, 4 authors, 2016-01-08

[PATCH 1/4] soc: mediatek: Separate scpsys driver common code

From: James Liao <hidden>
Date: 2015-12-30 10:09:11
Also in: linux-devicetree, linux-mediatek, lkml

Hi Arnd,

On Wed, 2015-12-30 at 09:52 +0100, Arnd Bergmann wrote:
On Wednesday 30 December 2015 14:41:43 James Liao wrote:
quoted
diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
index 0a4ea80..eca6fb7 100644
--- a/drivers/soc/mediatek/Kconfig
+++ b/drivers/soc/mediatek/Kconfig
@@ -22,11 +22,20 @@ config MTK_PMIC_WRAP
 
 config MTK_SCPSYS
        bool "MediaTek SCPSYS Support"
-       depends on ARCH_MEDIATEK || COMPILE_TEST
-       default ARM64 && ARCH_MEDIATEK
        select REGMAP
        select MTK_INFRACFG
        select PM_GENERIC_DOMAINS if PM
        help
          Say yes here to add support for the MediaTek SCPSYS power domain
          driver.
+
+config MTK_SCPSYS_MT8173
+       bool "MediaTek MT8173 SCPSYS Support"
+       depends on ARCH_MEDIATEK || COMPILE_TEST
+       select MTK_SCPSYS
+       default ARCH_MEDIATEK
Please don't "select" a user-visible Kconfig symbol. Either hide MTK_SCPSYS
by removing the string behind 'bool', or make this "depends on MTK_SCPSYS".
It looks something wrong during cherry-pick. MTK_SCPSYS should be
invisible from user. I'll remove the string behind 'bool' in next patch.


Best regards,

James
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help