Am Dienstag, 29. Dezember 2015, 14:59:59 schrieb Florian Fainelli:

On December 27, 2015 11:22:20 PM PST, Xing Zheng [off-list ref] 

wrote:

quoted

The RK3036's GRFs offset are different with RK3066/RK3188, and need to
set
mac TX/RX clock before probe emac.

Signed-off-by: Xing Zheng <redacted>
---

<snip>

quoted

};

static const struct of_device_id emac_rockchip_dt_ids[] = {

-	{ .compatible = "rockchip,rk3066-emac", .data =
&emac_rockchip_dt_data[0] },
-	{ .compatible = "rockchip,rk3188-emac", .data =
&emac_rockchip_dt_data[1] },
+	{ .compatible = "rockchip,rk3036-emac", .data =
&emac_rockchip_dt_data[0] },
+	{ .compatible = "rockchip,rk3066-emac", .data =
&emac_rockchip_dt_data[1] },
+	{ .compatible = "rockchip,rk3188-emac", .data =
&emac_rockchip_dt_data[2] },

	{ /* Sentinel */ }

Food for thought, you might want to use an enum here to index
emac_rockchip_dt_data which would be less error prone if you add/remove
entries in this structure.

Or just have the structs separately and not in array-form at all, aka
rk3066_emac_dt_data, rk3036_emac_dt_data.

I don't think the original array really improves anything.