[PATCH v7 3/4] gicv2m: Refactor to prepare for ACPI support
From: helgaas@kernel.org (Bjorn Helgaas)
Date: 2015-12-16 22:12:14
Also in:
linux-acpi, linux-pci, lkml
On Thu, Dec 10, 2015 at 08:55:29AM -0800, Suravee Suthikulpanit wrote:
This patch replaces the struct device_node with struct fwnode_handle since this structure is common between DT and ACPI. It also refactors gicv2m_init_one() to prepare for ACPI support. The only functional change is removing the node name from pr_info. Reviewed-by: Marc Zyngier <redacted> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
quoted hunk ↗ jump to hunk
@@ -359,10 +355,10 @@ static int __init gicv2m_init_one(struct device_node *node, } list_add_tail(&v2m->entry, &v2m_nodes); - pr_info("Node %s: range[%#lx:%#lx], SPI[%d:%d]\n", node->name, - (unsigned long)v2m->res.start, (unsigned long)v2m->res.end, - v2m->spi_start, (v2m->spi_start + v2m->nr_spis)); + pr_info("range[%#lx:%#lx], SPI[%d:%d]\n", + (unsigned long)res->start, (unsigned long)res->end, + v2m->spi_start, (v2m->spi_start + v2m->nr_spis));
You didn't change this, but I don't think this message has enough context. It's pretty cryptic all by itself. It'd be nice if it could at least include a device name, e.g., if you could use dev_info(). If that's possible, I guess a separate patch would be appropriate, since there are other similar things in this file. Bjorn