On Tue, 2015-12-15 at 15:13 -0600, Dan Williams wrote:

On Tue, 2015-12-15 at 16:01 -0500, David Miller wrote:

quoted

From: Bjorn Andersson <redacted>
Date: Fri, 11 Dec 2015 12:41:59 -0800

quoted

+static unsigned int qrtr_local_nid = 1;
+module_param_named(node_id, qrtr_local_nid, uint, S_IRUGO);
+MODULE_PARM_DESC(idVendor, "Local Node Identifier");

Also s/idVendor/node_id?

Well, not that it matters if the module parameter gets removed...

Dan

Dan

quoted

Module parameters suck.

Allow the user to choose this dynamically.  You have roughtly two
choices.

1) Subvert the 'protocol' field passed to ->create() and use that,
it
is
   being ignored otherwise.

2) Put it into the socket address for bind().
--
To unsubscribe from this list: send the line "unsubscribe netdev"
in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html