[PATCH V6 18/26] coresight: etb10: implementing AUX space API
From: alexander.shishkin@linux.intel.com (Alexander Shishkin)
Date: 2015-12-11 14:00:40
Also in:
lkml
From: alexander.shishkin@linux.intel.com (Alexander Shishkin)
Date: 2015-12-11 14:00:40
Also in:
lkml
Mathieu Poirier [off-list ref] writes:
+static void *etb_get_config(struct coresight_device *csdev, int cpu,
+ void **pages, int nr_pages, bool overwrite)
+{
+ int node;
+ struct cs_buffers *buf;
+
+ if (cpu == -1)
+ cpu = smp_processor_id();
+ node = cpu_to_node(cpu);
+
+ buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node);
+ if (!buf)
+ return NULL;
+
+ buf->snapshot = overwrite;
+ buf->nr_pages = nr_pages;
+ buf->data_pages = pages;
+
+ return buf;
+}Nitpick: why is this called "get_config"? I was just looking for something else and noticed that both sources and sinks have .get_config() callback (I was looking for the source's one), but this guy doesn't seem to be getting any config, but rather allocating a buffer descriptor. Regards, -- Alex