[PATCH 06/10] ARM: realview: enable multiplatform

On Thursday 10 December 2015 11:04:31 Linus Walleij wrote:

On Wed, Nov 25, 2015 at 5:32 PM, Arnd Bergmann [off-list ref] wrote:

quoted

All obstacles are out of the way by now, so we can finally move realview
to multiplatform.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Linus Walleij <redacted>
Cc: Russell King <redacted>

(...)

quoted

-obj-y                                  := core.o
 obj-$(CONFIG_REALVIEW_DT)              += realview-dt.o
+ifdef $(CONFIG_ATAGS)
+obj-y                                  := core.o
 obj-$(CONFIG_MACH_REALVIEW_EB)         += realview_eb.o
 obj-$(CONFIG_MACH_REALVIEW_PB11MP)     += realview_pb11mp.o
 obj-$(CONFIG_MACH_REALVIEW_PB1176)     += realview_pb1176.o
 obj-$(CONFIG_MACH_REALVIEW_PBA8)       += realview_pba8.o
 obj-$(CONFIG_MACH_REALVIEW_PBX)                += realview_pbx.o
+endif

This isn't working. Even if CONFIG_ATAGS is set, none of the files
inside this ifdef $(CONFIG_ATAGS) are compiled. Does Kconfig
only support if and not ifdef?

Oh, it's a silly typo:

it should be "ifdef CONFIG_ATAGS", not "ifdef $(CONFIG_ATAGS)"

Sorry about that.

	Arnd