Thread (12 messages) 12 messages, 5 authors, 2015-12-08

[PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.

From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-12-07 11:16:34
Also in: linux-mm, lkml

On Monday 07 December 2015 10:26:16 Jon Hunter wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
index af461b935137..e59a75a308bc 100644
--- a/arch/arm64/mm/mmap.c
+++ b/arch/arm64/mm/mmap.c
@@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void)
 {
        unsigned long rnd;
 
-ifdef CONFIG_COMPAT
+#ifdef CONFIG_COMPAT
        if (test_thread_flag(TIF_32BIT))
                rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
        else
Cheers
Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
and change this code to use

	if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help