On Mon, 30 Nov 2015 19:59:53 +0800
Shannon Zhao [off-list ref] wrote:

Hi Marc,

On 2015/11/30 19:42, Marc Zyngier wrote:

quoted

quoted

+static void reset_pmceid(struct kvm_vcpu *vcpu, const struct sys_reg_desc *r)

quoted

+{
+	u64 pmceid;
+
+	if (r->reg == PMCEID0_EL0 || r->reg == c9_PMCEID0)

That feels wrong. We should only reset the 64bit view of the sysregs,
as the 32bit view is directly mapped to it.

Just to confirm, if guest access c9_PMCEID0, KVM will trap this register
with the register index as PMCEID0_EL0? Or still as c9_PMCEID0?

The traps are per execution mode (you'll get c9_PMCEID0 with a 32bit
guest). But the reset function is only concerned with the 64bit view.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.