[PATCH] cpufreq: scpi: Add dependency on SCPI clk driver
From: Punit Agrawal <hidden>
Date: 2015-11-18 13:06:13
Also in:
linux-pm
Viresh Kumar [off-list ref] writes:
On 17-11-15, 18:14, Punit Agrawal wrote:quoted
The SCPI clk driver registers the virtual cpufreq device that kicks off initialisation of the SCPI cpufreq driver. Make the dependendency explicit in Kconfig.That's not a dependency. Any other part of the kernel can add this *virtual* cpufreq device to get it going.
Any part can add the virtual cpufreq device but for scpi-cpufreq it is done by clk-scpi. I can re-word it for clarity.
But, we do have dependency the other way round. clk_get() will fail for the cpufreq driver if SCPI-clk driver is missing and perhaps that's what you need to mention in the changelog.quoted
Fixes: 8def31034d03 ("cpufreq: arm_big_little: add SCPI interface driver") Signed-off-by: Punit Agrawal <redacted> Cc: Sudeep Holla <redacted> Cc: Rafael J. Wysocki <redacted> Cc: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/Kconfig.arm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 1582c1c..dadfdd4 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm@@ -201,7 +201,7 @@ config ARM_SA1110_CPUFREQ config ARM_SCPI_CPUFREQ tristate "SCPI based CPUfreq driver" - depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL + depends on ARM_BIG_LITTLE_CPUFREQ && ARM_SCPI_PROTOCOL && COMMON_CLK_SCPIThis looks fine.
I'll send an updated version to be picked up. Thanks for taking a look.