Thread (1 message) 1 message, 1 author, 2015-11-20

[PATCH 03/10] dt-bindings: interrupt-controllers: add description of SIC1 and SIC2

From: vz@mleia.com (Vladimir Zapolskiy)
Date: 2015-11-20 18:16:56
Also in: linux-devicetree

Hi Marc,

On 20.11.2015 20:02, Marc Zyngier wrote:
On 20/11/15 17:52, Vladimir Zapolskiy wrote:
quoted
Hi Rob,

On 20.11.2015 18:58, Rob Herring wrote:
quoted
On Fri, Nov 20, 2015 at 03:28:38AM +0200, Vladimir Zapolskiy wrote:
quoted
NXP LPC32xx has three interrupt controllers, namely root Main
Interrupt Controller (MIC) and two supplementary Sub Interrupt
Controllers (SIC1 and SIC2), four interrupt outputs from SIC1 and SIC2
are connected to MIC.

Also the change describes two additional optional properties:
* interrupt-controller-name - human readable name of an interrupt
  controller,
Why? compatible is human readable. If you don't like that, then put the 
string in the driver.
in runtime I'd like to differentiate various IRQ chips by name. Here for
example I have one compatible "*-sic" and two actual IRQ chips SIC1 and
SIC2. If I read /proc/interrupts or /sys/kernel/debug/irq_domain_mapping
I would prefer to visualize interrupts from SIC1 and SIC2.

I understand that this property is not hardware specific, but there are
plenty of similar properties like "label" etc. Probably renaming of the
property may help?
You can always generate the name based on the probing order or the address.
But the probing order is not guaranteed in general.

It might be confusing, if the spec operates with strictly defined SIC1
and SIC2 names, and in runtime the names of interrupt controllers are
swapped.

Another option might be to introduce different compatibles, but I think
optional label/name property is better.

--
With best wishes,
Vladimir
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help