Thread (2 messages) read the whole thread 2 messages, 2 authors, 2015-11-20

[PATCH 03/10] dt-bindings: interrupt-controllers: add description of SIC1 and SIC2

From: vz@mleia.com (Vladimir Zapolskiy)
Date: 2015-11-20 17:52:56
Also in: linux-devicetree

Hi Rob,

On 20.11.2015 18:58, Rob Herring wrote:
On Fri, Nov 20, 2015 at 03:28:38AM +0200, Vladimir Zapolskiy wrote:
quoted
NXP LPC32xx has three interrupt controllers, namely root Main
Interrupt Controller (MIC) and two supplementary Sub Interrupt
Controllers (SIC1 and SIC2), four interrupt outputs from SIC1 and SIC2
are connected to MIC.

Also the change describes two additional optional properties:
* interrupt-controller-name - human readable name of an interrupt
  controller,
Why? compatible is human readable. If you don't like that, then put the 
string in the driver.
in runtime I'd like to differentiate various IRQ chips by name. Here for
example I have one compatible "*-sic" and two actual IRQ chips SIC1 and
SIC2. If I read /proc/interrupts or /sys/kernel/debug/irq_domain_mapping
I would prefer to visualize interrupts from SIC1 and SIC2.

I understand that this property is not hardware specific, but there are
plenty of similar properties like "label" etc. Probably renaming of the
property may help?
quoted
* wakeup-sources - list of mappings between a hardware interrupt and
  its correspondent wakeup source to exit CPU STOP mode.
This needs further discussion as I mentioned.
Ok.
The rest looks fine.
Thanks for review.

--
Best wishes,
Vladimir
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help