Hi Herbert,

On Mon, Nov 30, 2015 at 2:09 PM, Herbert Xu [off-list ref] wrote:

On Mon, Nov 30, 2015 at 02:06:03PM +0530, Rameshwar Sahu wrote:

quoted

On Mon, Nov 16, 2015 at 2:42 PM,  [off-list ref] wrote:

quoted

From: Rameshwar Prasad Sahu <redacted>

This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver
and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC has
DMA engine capable of performing CRC32C computations.

v2 changes:
        1. Added helper function in dmaengine framework
        2. Documented CRC32C support in Documentations/dmaengine/provider.txt
        3. Fixed algo name
        4. Fixed coding style issues

Signed-off-by: Rameshwar Prasad Sahu <redacted>
---

Rameshwar Prasad Sahu (3):
  dmaengine: Add support for new feature CRC32C computations
  dmaengine: xgene-dma: Add support for CRC32C computations via DMA
    engine
  Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver

 Documentation/dmaengine/provider.txt |    3 +
 drivers/crypto/Kconfig               |    8 +
 drivers/crypto/Makefile              |    1 +
 drivers/crypto/xgene-crc32c.c        |  234 +++++++++++++++++++++++++
 drivers/dma/dmaengine.c              |    2 +
 drivers/dma/xgene-dma.c              |  314 ++++++++++++++++++++++++++++++++--
 include/linux/dmaengine.h            |   13 ++
 7 files changed, 560 insertions(+), 15 deletions(-)
 create mode 100755 drivers/crypto/xgene-crc32c.c

Any Comments on above patchset ??

The main user of crc32c is lib/libcrc32c.c.  Unfortunately it is
entire synchronous so it won't be able to use your crc32c driver
at all.

This is asynchronous implementation of the crc32c, mainly for
offloading the computations, So client (who want to use it) can call
it as like other async crypto algos available in linux/crypto, so they
have frame the layer on top of this.

So who is going to be using this?

One of our client is using this layer for offloading the crc32c to our
dmaengine hw.

Cheers,
--
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt