Thread (1 message) 1 message, 1 author, 2015-11-17

[PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer

From: Joshua Clayton <hidden>
Date: 2015-11-17 18:58:59
Also in: linux-spi, lkml

On Tuesday, November 17, 2015 05:41:56 PM Mark Brown wrote:
On Tue, Nov 17, 2015 at 07:24:21AM -0800, Joshua Clayton wrote:
quoted
default_rx and rx are needlessly different.
Use one buffer, local to transmit()
Why?  This isn't what I'd expect from black boxing the API, from a
userspace point of view the transfer is atomic and in an ideal world
we'd be able to do direct to/from memory transfers rather than memcpy()
into kernel space which means that userspace should assume the transfers
are going on simultaneously even if they don't currently.
The important thing here was to get rid of the default_rx buffer.
I just noticed that the output can be set up completely within the scope
of the transmit function, since the operands are global. But I would be
just as happy to set it up at the top level. I'll change this in V2

--
~Joshua Clayton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help