[PATCH 3/6] serial: mid8250: select CONFIG_RATIONAL
From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
Date: 2015-11-16 16:56:01
Also in:
linux-serial, lkml
On Mon, 2015-11-16 at 16:48 +0100, Arnd Bergmann wrote:
The Intel MID support got split out from the PCI 8250 driver, and that now causes a build error when no other driver selects CONFIG_RATIONAL:
Already published. https://lkml.org/lkml/2015/11/12/272 It's not first time you send patches that already have been published. I think you use some testing automation which doesn't take into consideration what is sent in mailing lists.
quoted hunk ↗ jump to hunk
drivers/built-in.o: In function `mid8250_set_termios': (.text+0x77418): undefined reference to `rational_best_approximation' This adds an explicit 'select' like the combined driver had before. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: d9eda9bab237 ("serial: 8250_pci: Intel MID UART support to its own driver") Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- ?drivers/tty/serial/8250/Kconfig | 1 + ?1 file changed, 1 insertion(+)diff --git a/drivers/tty/serial/8250/Kconfigb/drivers/tty/serial/8250/Kconfig index e6f5e12a2d83..6412f1455beb 100644--- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig@@ -373,6 +373,7 @@ config SERIAL_8250_MID? depends on SERIAL_8250 && PCI ? select HSU_DMA if SERIAL_8250_DMA ? select HSU_DMA_PCI if X86_INTEL_MID + select RATIONAL ? help ? ??Selecting this option will enable handling of the extra features ? ??present on the UART found on Intel Medfield SOC and various other
-- Andy Shevchenko [off-list ref] Intel Finland Oy