Thread (11 messages) 11 messages, 3 authors, 2015-11-17

[RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

From: Linus Walleij <hidden>
Date: 2015-11-05 13:40:13
Also in: linux-gpio, lkml

On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
[off-list ref] wrote:
ARCH_SUNXI selects RESET_CONTROLLER.
The dependency "depends on RESET_CONTROLLER" is already met.

Signed-off-by: Masahiro Yamada <redacted>
NACK, this pin controller needs that as dependency, I don't worry
that it's overspecified.

They both do this:
#include <linux/reset.h>

And the object should specify its dependencies, not rely on them
being implicitly available.

The dep is there for human readers too, not just machines. And to
them, this is helpful information.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help