[PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY
From: computersforpeace@gmail.com (Brian Norris)
Date: 2015-11-04 01:13:54
Also in:
dri-devel, linux-devicetree, linux-rockchip, linux-samsung-soc, lkml
Hi Yakir, On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote:
On 11/03/2015 12:38 PM, Brian Norris wrote:quoted
On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: (FYI, I came across this by inspection when comparing Heiko's 'somewhat-stable' branch [1] with this series. The former brings up eDP fine on veyron-jaq, whereas this one doesn't yet, even with the above change. Still debugging the issue.)Hmm... I'm not sure whether your eDP screen have the hotplug signal, so I
I believe hotplug is hooked up but...
think you can try to add "analogix,force-hpd" flag into
rk3288-veyron-jaq.dts
&edp {
analogix,need-force-hpd;
}...already tried, just in case. No luck.
quoted hunk ↗ jump to hunk
If that changes couldn't fix the problem, guess you may need max the panel power up delay time which pointed by Heiko. Like: Thanks, - Yakirdiff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.cb/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 4fa5f69..546a506 100644--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c@@ -82,6 +82,13 @@ static int analogix_dp_detect_hpd(structanalogix_dp_device *dp) */ dev_dbg(dp->dev, "failed to get hpd plug status, try to force hpd\n"); + /* + * Hotplug signal would indicate the right time to operate + * panel after poweron, but if the hotplug is missing, then + * panel would need wait hundreds of milliseconds at here. + */ + mdelay(100); + analogix_dp_force_hpd(dp); if (analogix_dp_get_plug_in_status(dp) != 0) {
I'll give that a try. Per Heiko's suggestion, I've already hacked around with adding delays in the regulator node, but this could give slightly different behavior. I doubt it'll help, but I'll let you know if it does. Regards, Brian