On Tue, Oct 27, 2015 at 09:13:22PM -0500, Timur Tabi wrote:
Ard Biesheuvel wrote:
quoted
No. I screwed up the patch since the trailing ) should not be there,
but we do need to round first, and only then add the offset.
But if the offset is not a multiple of 2MB, won't the address passed
to allocate_pages be unaligned? I'll test your patch on our system,
but I thought the problem was that the allocated address must be
aligned.
The kernel needs to be loaded at an address which is text_offset bytes
past a 2M-aligned base. It is not loaded at the 2M-aligned base itself.
Ard's patch correctly findd a 2M-aligned base, then adds the text
offset.
Mark.