On Fri, Oct 23, 2015 at 11:27 AM, Linus Walleij
[off-list ref] wrote:

On Thu, Oct 15, 2015 at 9:08 PM, Stephen Boyd [off-list ref] wrote:

quoted

On 10/15, Linus Walleij wrote:

quoted

@@ -151,10 +174,19 @@ struct clk *icst_clk_register(struct device *dev,
      init.flags = CLK_IS_ROOT;
      init.parent_names = (parent_name ? &parent_name : NULL);
      init.num_parents = (parent_name ? 1 : 0);
+     icst->map = regmap_init_mmio(NULL, base, &icst_regmap_conf);
+     if (IS_ERR(icst->map)) {
+             int ret;
+
+             pr_err("could not initialize ICST regmap\n");
+             kfree(icst);
+             ret = PTR_ERR(icst->map);

drivers/clk/versatile/clk-icst.c:183
icst_clk_register() error: dereferencing freed memory 'icst'
drivers/clk/versatile/clk-icst.c:184
icst_clk_register() warn: possible memory leak of 'pclone'

The pclone warning is correct, nice catch. (Fixing it.)

Turns out that this was around for ages, so sent a separate
fix for -stable.

Yours,
Linus Walleij