Hello!

-----Original Message-----
From: linux-samsung-soc-owner at vger.kernel.org [mailto:linux-samsung-soc-owner at vger.kernel.org]
On Behalf Of Pankaj Dubey
Sent: Thursday, October 29, 2015 8:28 PM
To: Pavel Fedin
Cc: devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-samsung-soc;
linux-kernel at vger.kernel.org; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala;
Kukjin Kim; Krzysztof Kozlowski
Subject: Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

Hi Pavel,

On 29 October 2015 at 18:12, Pavel Fedin [off-list ref] wrote:

quoted

This machine uses own SoC device tree file, add missing part.

Signed-off-by: Pavel Fedin <redacted>
---
 arch/arm/boot/dts/exynos5410.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
index 4603356..da6a8fa0e 100644
--- a/arch/arm/boot/dts/exynos5410.dtsi
+++ b/arch/arm/boot/dts/exynos5410.dtsi

@@ -101,6 +101,15 @@
                        reg = <0x10000000 0x100>;
                };

+               sromc: sromc at 12250000 {
+                       #address-cells = <1>;
+                       #size-cells = <1>;
+                       ranges;
+

We do not need to specify these three properties as they are already
present in parent node "soc".

 We do, otherwise dtc complains about defaults of #address-cells = 2 and #size-cells=1, and without empty "ranges" subnode's resources are not correctly translated.

quoted

+                       compatible = "samsung,exynos-srom";
+                       reg = <0x12250000 0x14>;
+               };
+
                pmu_system_controller: system-controller at 10040000 {
                        compatible = "samsung,exynos5410-pmu", "syscon";
                        reg = <0x10040000 0x5000>;

@@ -133,6 +142,12 @@
                                                <10 &gic 0 130 0>,
                                                <11 &gic 0 131 0>;
                        };
+
+                       arch_timer {
+                               compatible = "arm,armv7-timer";
+                               clock-frequency = <24000000>;
+                       };
+

This change should not be part of this patch.

 Ooops, thank you very much, this should not have been here at all. This is a leftover from my experiments, i was tracing DT parsing code and added it just for test, to see why timer gets probed as a subnode.
 Just forgot to remove it afterwards and it slipped into the patch.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia