Thread (9 messages) 9 messages, 5 authors, 2015-10-30

[PATCH] gpio: zynq: Implement irq_(request|release)_resources

From: Linus Walleij <hidden>
Date: 2015-10-28 15:20:46
Also in: linux-gpio, lkml

On Tue, Oct 27, 2015 at 6:54 PM, Grygorii Strashko
[off-list ref] wrote:
[Me]
quoted
Do you mean that these functions contain calls to non-atomic
functions?
Oh. No, I have to be more specific :(
if GPIOx driver defines custom .irq_(request|release)_resources() callbacks
they will *overwrite* standard GPIOirqchip callbacks.
(commit: 8b67a1f "gpio: don't override irq_*_resources() callbacks")

As result, such GPIOx driver should *re-implement* the same functionality in
its .irq_(request|release)_resources() callbacks as implemented in
gpiochip_irq_reqres()/gpiochip_irq_relres().
Yes that goes for all drivers not using gpiochip_add_irqchip().
Not everyone uses that ... and for those supplying their own
implementations of these functions.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help