Thread (3 messages) flat view 3 messages, 3 authors, 2015-10-30
STALE3983d

[PATCH] ARM: fix bug in vdsomunge swab32 macro

From: H. Nikolaus Schaller <hidden>
Date: 2015-10-28 15:10:59
Also in: lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")

unfortunately introduced a bug created but not found during
discussion and patch simplification.

Reported-by: Efraim Yawitz <redacted>
Signed-off-by: H. Nikolaus Schaller <redacted>
---
 arch/arm/vdso/vdsomunge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
index 0cebd98..f645527 100644
--- a/arch/arm/vdso/vdsomunge.c
+++ b/arch/arm/vdso/vdsomunge.c
@@ -66,7 +66,7 @@
 	((((x) & 0x000000ff) << 24) | \
 	 (((x) & 0x0000ff00) <<  8) | \
 	 (((x) & 0x00ff0000) >>  8) | \
-	 (((x) & 0xff000000) << 24))
+	 (((x) & 0xff000000) >> 24))
 
 #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
 #define HOST_ORDER ELFDATA2LSB
-- 
2.5.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help