[PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
From: Krzysztof Kozlowski <hidden>
Date: 2015-10-28 13:13:50
Also in:
lkml
W dniu 28.10.2015 o 18:55, Lee Jones pisze:
On Wed, 28 Oct 2015, Uwe Kleine-K?nig wrote:quoted
Hello, On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote:quoted
On 28.10.2015 17:24, Lee Jones wrote:quoted
You guys are pushing back like this is some kind of demotion. That's not the case at all. All it does is better describe the (very worthy) function you *actually* provide.It is getting into dispute about entire change of yours... which is not what I want. I agree with your general idea but I was referring only to that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which would fall into same category).Not being affected by this change, I wonder what the technical difference is if someone is listed as reviewer instead of maintainer. Does get_maintainer.pl behave differently?Reviewers are people who should be Cc'ed on all patches, as are Maintainers, so no, fundamentally they are treated the same by a Submitter. Here is some output for Maintainers/Reviews from get_maintainer.pl. $ ./scripts/get_maintainer.pl -f arch/arm/boot/dts/vf500.dtsi Shawn Guo [off-list ref] (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE) Sascha Hauer [off-list ref] (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE) Stefan Agner [off-list ref] (reviewer) Russell King [off-list ref] (maintainer:ARM PORT) linux-arm-kernel at lists.infradead.org (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE) devicetree at vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-kernel at vger.kernel.org (open list) I'm sure we can make the output even more similar by listing the MAINTAINERS tag after "reviewer" too.
And here is the output of drivers/mfd/sec-core.c *before*: Sangbeom Kim [off-list ref] (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS) Krzysztof Kozlowski [off-list ref] (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS) Lee Jones [off-list ref] (supporter:MULTIFUNCTION DEVICES (MFD)) and after (where I am listed as reviewer): Sangbeom Kim [off-list ref] (reviewer) Krzysztof Kozlowski [off-list ref] (reviewer) Lee Jones [off-list ref] (supporter:MULTIFUNCTION DEVICES (MFD)) Maybe it should be "supporter reviewer"? Best regards, Krzysztof