[PATCH 5/8] [media] v4l: xilinx-vipp: add missing of_node_put
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
Date: 2015-10-26 01:20:37
Also in:
kernel-janitors, linux-media, lkml
Hi Julia, Thank you for the patch. On Sunday 25 October 2015 14:57:04 Julia Lawall wrote:
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // <smpl> @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { ... when != of_node_put(child) when != e = child ( return child; + of_node_put(child); ? return ...; ) ... } // </smpl> Signed-off-by: Julia Lawall <redacted>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
--- drivers/media/platform/xilinx/xilinx-vipp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/media/platform/xilinx/xilinx-vipp.cb/drivers/media/platform/xilinx/xilinx-vipp.c index 7b7cb9c..b9bf24f 100644--- a/drivers/media/platform/xilinx/xilinx-vipp.c +++ b/drivers/media/platform/xilinx/xilinx-vipp.c@@ -476,8 +476,10 @@ static int xvip_graph_dma_init(structxvip_composite_device *xdev) for_each_child_of_node(ports, port) { ret = xvip_graph_dma_init_one(xdev, port); - if (ret < 0) + if (ret < 0) { + of_node_put(port); return ret; + } } return 0;
-- Regards, Laurent Pinchart