Thread (7 messages) 7 messages, 4 authors, 2015-10-22

[RESEND PATCH] pwm-backlight: fix the panel power sequence

flat view

From: YH Huang <hidden>
Date: 2015-10-16 08:50:48
Also in: linux-fbdev, linux-mediatek, linux-pwm, lkml

On Fri, 2015-10-16 at 10:36 +0200, Sascha Hauer wrote:
On Fri, Oct 16, 2015 at 09:37:34AM +0800, YH Huang wrote:
quoted
In order to match the panel power sequence, disable the enable_gpio
in the probe function. Also, reorder the code in the power_on and
power_off function to match the timing.
@@ -241,8 +242,7 @@ static int pwm_backlight_probe(struct platform_device *pdev)
 	pb->dev = &pdev->dev;
 	pb->enabled = false;
 
-	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable",
-						  GPIOD_OUT_HIGH);
+	pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable");
Please actually test your patches. This change here won't compile.

Sascha
I will send patch v2 to fix it.

YH Huang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help