Sergei,

On Tue, Oct 13, 2015 at 10:33 PM, Sergei Shtylyov
[off-list ref] wrote:

Hello.

On 10/13/2015 12:39 PM, Bayi Cheng wrote:

quoted

Add Mediatek nor flash node

Signed-off-by: Bayi Cheng <redacted>
---
  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++
  1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi

b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index d18ee42..385c2e4 100644

--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi

@@ -365,6 +365,21 @@
                        status = "disabled";
                };

+               nor_flash: spi at 1100d000 {

   I don't think this is a good label name for a SPI controller.

You think "spi" is not a good name for SPI controller?
Or you mean the label "nor_flash"?

Would you prefer:

  spi_nor_flash: spi at 1100d000

quoted

+                       compatible = "mediatek,mt8173-nor";
+                       reg = <0 0x1100d000 0 0xe0>;
+                       clocks = <&pericfg CLK_PERI_SPI>,
+                                <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
+                       clock-names = "spi", "sf";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       flash at 0 {
+                               compatible = "jedec,spi-nor";
+                               reg = <0>;
+                       };
+               };
+
                i2c3: i2c3 at 11010000 {

   Grr, the name should be "i2c at 11010000".

Don't worry.  This is already fixed in Matthias' tree:
  https://github.com/mbgg/linux-mediatek/commit/1ee35c05d9c67771d649f687e6f76e61e76eb779

-Dan

[...]

MBR, Sergei