Thread (5 messages) 5 messages, 2 authors, 2015-10-12

[PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

From: Yang, Wenyou <hidden>
Date: 2015-10-12 07:48:27
Also in: linux-rtc, lkml

Hi Alexandre,
-----Original Message-----
From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com]
Sent: 2015?10?12? 14:53
To: Yang, Wenyou
Cc: Alessandro Zummo; Ferre, Nicolas; Desroches, Ludovic; rtc-
linux at googlegroups.com; linux-kernel at vger.kernel.org; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to
suspending

Hi Wenyou,

On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
quoted
This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity.
Is this a new issue appearing with the sama5d2 or was it present from the
beginning?
With the sama5d2 ULP1 mode, not from the beginning.
quoted
Signed-off-by: Wenyou Yang <redacted>
---

 drivers/rtc/rtc-at91rm9200.c |    2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c
b/drivers/rtc/rtc-at91rm9200.c index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
 	/* this IRQ is shared with DBGU and other hardware which isn't
 	 * necessarily doing PM like we are...
 	 */
+	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
 	at91_rtc_imr = at91_rtc_read_imr()
 			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
 	if (at91_rtc_imr) {
--
1.7.9.5
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Best Regards,
Wenyou Yang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help